Skip to content

refactor: use utils.parse_time instead of datetime.fromisoformat - #3299

Merged
Paillat-dev merged 4 commits into
masterfrom
refactor/parse-time-utils
Jul 29, 2026
Merged

refactor: use utils.parse_time instead of datetime.fromisoformat#3299
Paillat-dev merged 4 commits into
masterfrom
refactor/parse-time-utils

Conversation

@vmphase

@vmphase vmphase commented Jul 8, 2026

Copy link
Copy Markdown
Member

Summary

Replaced remaining datetime.datetime.fromisoformat usage with utils.parse_time for better consistency with other parts of the codebase (was planning to do it since #3259)

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

@pycord-app

pycord-app Bot commented Jul 8, 2026

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3299/head:pr-3299
git checkout pr-3299

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3299/head

@vmphase
vmphase requested a review from a team as a code owner July 11, 2026 05:34
@vmphase
vmphase requested review from a team July 11, 2026 05:34

@Paillat-dev Paillat-dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Paillat-dev
Paillat-dev requested a review from Icebluewolf July 26, 2026 10:17
@Paillat-dev
Paillat-dev merged commit a371158 into master Jul 29, 2026
31 checks passed
@Paillat-dev
Paillat-dev deleted the refactor/parse-time-utils branch July 29, 2026 17:29
@github-project-automation github-project-automation Bot moved this from Todo to Done in Pycord Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants